netdev - Re: [PATCH net-next 0/4] selftests: drv-net: round some sharp edges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 21:45:49 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 linux-kselftest@...r.kernel.org, 
 willemdebruijn.kernel@...il.com, 
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 0/4] selftests: drv-net: round some sharp edges

Jakub Kicinski wrote:
> I had to explain how to run the driver tests twice already.
> Improve the README so we can just point to it.
> Also fix a potential problem with the SSH remote sessions.
> 
> Jakub Kicinski (4):
>   selftests: drv-net: force pseudo-terminal allocation in ssh
>   selftests: drv-net: extend the README with more info and example
>   selftests: drv-net: reimplement the config parser
>   selftests: drv-net: validate the environment
> 
>  .../testing/selftests/drivers/net/README.rst  | 95 ++++++++++++++++---
>  .../selftests/drivers/net/lib/py/env.py       | 46 ++++++---
>  .../drivers/net/lib/py/remote_ssh.py          |  2 +-
>  3 files changed, 118 insertions(+), 25 deletions(-)

Left two minor points comments inline, but nothing important.
The clear documentation is really helpful, thanks.

Reviewed-by: Willem de Bruijn <willemb@...gle.com>