netdev - Re:Re: [PATCH net] net: wwan: Add net device name for error message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5a7151.250c.18f1e4425f4.Coremail.slark_xiao@163.com>
Date: Sat, 27 Apr 2024 14:35:33 +0800 (CST)
From: "Slark Xiao" <slark_xiao@....com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: loic.poulain@...aro.org, ryazanov.s.a@...il.com, johannes@...solutions.net, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH net] net: wwan: Add net device name for error message
 print


















At 2024-04-27 06:21:03, "Andrew Lunn" <andrew@...n.ch> wrote:
>>  	if (skb->len < sizeof(struct usb_cdc_ncm_nth16) +
>>  			sizeof(struct usb_cdc_ncm_ndp16)) {
>> -		net_err_ratelimited("frame too short\n");
>> +		net_err_ratelimited("mbim: frame too short\n");
>
>I don't know this code at all, but i think you can do
>
>dev_err_ratelimited(&mbim->mdev->dev, "frame too short\n");
>
>That way, it tells you which of the 42 mhi devices has received too
>short a frame.
>
>      Andrew
I tried in my case, and it will print:
mhi_wwan_mbim mhio_IP_HW0_MBIM: frame too short

I think it's much more complicated, isn't it?

Thanks