netdev - Re: [PATCH net-next v2 2/2] net: dsa: Remove adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0b22caa-59d7-497b-9b86-339535a8508c@broadcom.com>
Date: Mon, 29 Apr 2024 14:47:46 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: dsa: Remove adjust_link paths

On 4/29/24 13:00, Simon Horman wrote:
> On Mon, Apr 29, 2024 at 09:54:05AM -0700, Florian Fainelli wrote:
>> Now that we no longer any drivers using PHYLIB's adjust_link callback,
>> remove all paths that made use of adjust_link as well as the associated
>> functions.
>>
>> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> 
> ...
> 
>> @@ -1616,17 +1597,13 @@ static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
>>   					   phy_interface_t interface)
>>   {
>>   	struct dsa_port *dp = dsa_phylink_to_port(config);
>> -	struct phy_device *phydev = NULL;
> 
> Hi Florian,
> 
> I'm wondering if some changes got lost somewhere.
> 
> phydev is removed here...
> 
>>   	struct dsa_switch *ds = dp->ds;
>>   
>>   	if (dsa_port_is_user(dp))
>>   		phydev = dp->user->phydev;
> 
> ... assigned here, but not used.
> 
> Perhaps the three lines above should be removed?

Yes, sorry about that, rebase gone wrong on my side.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)