netdev - Re: [PATCH net-next] tcp: add tracepoint for tcp_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a60f567-98d3-485c-911c-6383a6c5379c@linux.alibaba.com>
Date: Tue, 30 Apr 2024 17:04:19 +0800
From: Philo Lu <lulie@...ux.alibaba.com>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: edumazet@...gle.com, rostedt@...dmis.org, mhiramat@...nel.org,
 mathieu.desnoyers@...icios.com, davem@...emloft.net, dsahern@...nel.org,
 kuba@...nel.org, fred.cc@...baba-inc.com, xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next] tcp: add tracepoint for tcp_write_err()



On 2024/4/30 16:27, Paolo Abeni wrote:
> On Fri, 2024-04-26 at 00:25 +0800, Philo Lu wrote:
>> This tracepoint can be used to trace tcp write error events, e.g.,
>> retransmit timeout. Though there is a tracepoint in sk_error_report(),
>> the value of sk->sk_err depends on sk->sk_err_soft, and we cannot easily
>> recognized errors from tcp_write_err().
> 
> Why not? you can look at the dumped sock protocol and ev. capture the
> sk_error_report tracepoint call-trace.
> 

Thanks for your suggestion, Paolo. I'll try to trace sk_error_report 
with its calling stack and see if this could solve my problem.

Though tcp_write_err() seems to be inlined in my system, upper callers 
may provides useful infomation. Let me have a try;)

Thanks.

> IMHO this provides little value and is not worthy.
> 
> Cheers,
> 
> Paolo