netdev - Re: [PATCH net-next] tcp: add tracepoint for tcp_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbeb89142a37a442d0a2184441a0fb4033b82ac8.camel@redhat.com>
Date: Tue, 30 Apr 2024 10:27:14 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Philo Lu <lulie@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: edumazet@...gle.com, rostedt@...dmis.org, mhiramat@...nel.org, 
	mathieu.desnoyers@...icios.com, davem@...emloft.net, dsahern@...nel.org, 
	kuba@...nel.org, fred.cc@...baba-inc.com, xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next] tcp: add tracepoint for tcp_write_err()

On Fri, 2024-04-26 at 00:25 +0800, Philo Lu wrote:
> This tracepoint can be used to trace tcp write error events, e.g.,
> retransmit timeout. Though there is a tracepoint in sk_error_report(),
> the value of sk->sk_err depends on sk->sk_err_soft, and we cannot easily
> recognized errors from tcp_write_err().

Why not? you can look at the dumped sock protocol and ev. capture the
sk_error_report tracepoint call-trace. 

IMHO this provides little value and is not worthy.

Cheers,

Paolo