netdev - Re: [PATCH net-next] selftests: netfilter: nft_concat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240501155920.GV2575892@kernel.org>
Date: Wed, 1 May 2024 16:59:20 +0100
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netfilter-devel@...r.kernel.org,
	pablo@...filter.org
Subject: Re: [PATCH net-next] selftests: netfilter: nft_concat_range.sh:
 reduce debug kernel run time

On Tue, Apr 30, 2024 at 04:58:07PM +0200, Florian Westphal wrote:

...

> diff --git a/tools/testing/selftests/net/netfilter/nft_concat_range.sh b/tools/testing/selftests/net/netfilter/nft_concat_range.sh

...

> @@ -1584,10 +1594,16 @@ for name in ${TESTS}; do
>  			continue
>  		fi
>  
> -		printf "  %-60s  " "${display}"
> +		[ "$KSFT_MACHINE_SLOW" = "yes" ] && count=1
> +
> +		printf "  %-32s  " "${display}"
> +		tthen=$(date +%s)
>  		eval test_"${name}"
>  		ret=$?
>  
> +		tnow=$(date +%s)
> +		printf "%5ds%-30s" $((tnow-tthen))
> + 

Hi Florian,

A minor nit: the format string above expects two variables, but only one
is passed.

Flagged by Shellcheck.


>  		if [ $ret -eq 0 ]; then
>  			printf "[ OK ]\n"
>  			info_flush

...