netdev - Re: [PATCH net-next v3 6/6] net: tn40xx: add PHYLIB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240501.154132.1306102883120815828.fujita.tomonori@gmail.com>
Date: Wed, 01 May 2024 15:41:32 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, jiri@...nulli.us,
 horms@...nel.org
Subject: Re: [PATCH net-next v3 6/6] net: tn40xx: add PHYLIB support

Hi,

On Tue, 30 Apr 2024 22:58:17 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> On Mon, Apr 29, 2024 at 01:38:27PM +0900, FUJITA Tomonori wrote:
>> This patch adds supports for multiple PHY hardware with PHYLIB. The
>> adapters with TN40xx chips use multiple PHY hardware; AMCC QT2025, TI
>> TLK10232, Aqrate AQR105, and Marvell 88X3120, 88X3310, and MV88E2010.
>> 
>> For now, the PCI ID table of this driver enables adapters using only
>> QT2025 PHY. I've tested this driver and the QT2025 PHY driver with
>> Edimax EN-9320 10G adapter.
>> 
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
>> ---
>>  drivers/net/ethernet/tehuti/Kconfig    |  2 +
>>  drivers/net/ethernet/tehuti/Makefile   |  2 +-
>>  drivers/net/ethernet/tehuti/tn40.c     | 34 +++++++++++---
>>  drivers/net/ethernet/tehuti/tn40.h     |  7 +++
>>  drivers/net/ethernet/tehuti/tn40_phy.c | 61 ++++++++++++++++++++++++++
>>  5 files changed, 99 insertions(+), 7 deletions(-)
>>  create mode 100644 drivers/net/ethernet/tehuti/tn40_phy.c
>> 
>> diff --git a/drivers/net/ethernet/tehuti/Kconfig b/drivers/net/ethernet/tehuti/Kconfig
>> index 4198fd59e42e..94fda9fd4cc0 100644
>> --- a/drivers/net/ethernet/tehuti/Kconfig
>> +++ b/drivers/net/ethernet/tehuti/Kconfig
>> @@ -27,6 +27,8 @@ config TEHUTI_TN40
>>  	tristate "Tehuti Networks TN40xx 10G Ethernet adapters"
>>  	depends on PCI
>>  	select FW_LOADER
>> +	select PHYLIB
>> +	select PHYLINK
> 
> You don't need both. PHYLINK will pull in PHYLIB.

Fixed.

>> @@ -1179,21 +1179,25 @@ static void tn40_link_changed(struct tn40_priv *priv)
>>  	u32 link = tn40_read_reg(priv,
>>  				 TN40_REG_MAC_LNK_STAT) & TN40_MAC_LINK_STAT;
>>  	if (!link) {
>> -		if (netif_carrier_ok(priv->ndev) && priv->link)
>> +		if (netif_carrier_ok(priv->ndev) && priv->link) {
>>  			netif_stop_queue(priv->ndev);
>> +			phylink_mac_change(priv->phylink, false);
>> +		}
>>  
>>  		priv->link = 0;
>>  		if (priv->link_loop_cnt++ > TN40_LINK_LOOP_MAX) {
>>  			/* MAC reset */
>>  			tn40_set_link_speed(priv, 0);
>> +			tn40_set_link_speed(priv, priv->phydev->speed);
> 
> You should not be references priv->phydev if you are using
> phylink. When phylink is managing an SFP, there might not be a phydev.
> phylink will tell you the speed when it calls your tn40_mac_config()
> callback.
> 
> I suggest you read the documentation in include/linux/phylink.h
> because this is very wrong.

Understood. I fixed the code not to use priv->phydev (except for
phylink_connect_phy).

Looks like phylink.h recommends using mac_link_up() over mac_config()
to get the link speed. So tn40_link_up() stores the speed in tn40_priv
for tn40_link_changed(). I also tried mac_config() but state->speed
isn't initialized properly.