netdev - Re: [PATCH net-next v3 3/6] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240501.154829.686841422238557872.fujita.tomonori@gmail.com>
Date: Wed, 01 May 2024 15:48:29 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, jiri@...nulli.us,
 horms@...nel.org
Subject: Re: [PATCH net-next v3 3/6] net: tn40xx: add basic Tx handling

Hi,

On Tue, 30 Apr 2024 22:40:47 +0200
Andrew Lunn <andrew@...n.ch> wrote:

>> --- a/drivers/net/ethernet/tehuti/tn40.c
>> +++ b/drivers/net/ethernet/tehuti/tn40.c
>> @@ -3,10 +3,1177 @@
>>  
>> +static inline void tn40_do_tx_db_ptr_next(struct tn40_txdb *db,
>> +					  struct tn40_tx_map **pptr)
> 
> inline functions are not liked in .c files. Leave it to the compiler
> to decide.

My bad, I should have found the warnings on this in patchwork before.


>> +{
>> +	++*pptr;
>> +	if (unlikely(*pptr == db->end))
>> +		*pptr = db->start;
>> +}
>> +
>> +static inline void tn40_tx_db_inc_rptr(struct tn40_txdb *db)
>> +{
>> +	tn40_do_tx_db_ptr_next(db, &db->rptr);
>> +}
>> +
>> +static inline void tn40_tx_db_inc_wptr(struct tn40_txdb *db)
>> +{
>> +	tn40_do_tx_db_ptr_next(db, &db->wptr);
>> +}
> 
> Functions like this are likely to be inlined even without the keyword.
> Please look through all the code and remove the inline keyword from .c
> files. They are O.K. in headers, so long as they are static inline.

Fixed.


>> +/* netdev tx queue len for Luxor. The default value is 1000.
>> + * ifconfig eth1 txqueuelen 3000 - to change it at runtime.
>> + */
>> +#define TN40_NDEV_TXQ_LEN 3000
> 
> This comment does not seem to match the #define?

Looks like so. I changed TN40_NDEV_TXQ_LEN to 1000.