netdev - Re: [PATCH net] vxlan: Pull inner IP header in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ5Ro3Q51YOM2mT1rgwfKiwq6UWtRCMkADsfiTF-=P8kg@mail.gmail.com>
Date: Wed, 1 May 2024 12:10:30 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: Guillaume Nault <gnault@...hat.com>, David Miller <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Amit Cohen <amcohen@...dia.com>, Petr Machata <petrm@...dia.com>, 
	Nikolay Aleksandrov <razor@...ckwall.org>, Jiri Benc <jbenc@...hat.com>, Breno Leitao <leitao@...ian.org>, 
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net] vxlan: Pull inner IP header in vxlan_rcv().

On Wed, May 1, 2024 at 12:03 PM Ido Schimmel <idosch@...dia.com> wrote:
>
> On Tue, Apr 30, 2024 at 06:50:13PM +0200, Guillaume Nault wrote:
> > Ensure the inner IP header is part of skb's linear data before reading
> > its ECN bits. Otherwise we might read garbage.
> > One symptom is the system erroneously logging errors like
> > "vxlan: non-ECT from xxx.xxx.xxx.xxx with TOS=xxxx".
> >
> > Similar bugs have been fixed in geneve, ip_tunnel and ip6_tunnel (see
> > commit 1ca1ba465e55 ("geneve: make sure to pull inner header in
> > geneve_rx()") for example). So let's reuse the same code structure for
> > consistency. Maybe we'll can add a common helper in the future.
> >
> > Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
> > Signed-off-by: Guillaume Nault <gnault@...hat.com>
>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !