netdev - Re: [PATCH net] vxlan: Pull inner IP header in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa710275-e2b5-4bce-a94a-40ad42cf6b83@blackwall.org>
Date: Wed, 1 May 2024 14:00:47 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Guillaume Nault <gnault@...hat.com>, David Miller <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
 Amit Cohen <amcohen@...dia.com>, Petr Machata <petrm@...dia.com>,
 Jiri Benc <jbenc@...hat.com>, Breno Leitao <leitao@...ian.org>,
 Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net] vxlan: Pull inner IP header in vxlan_rcv().

On 30/04/2024 19:50, Guillaume Nault wrote:
> Ensure the inner IP header is part of skb's linear data before reading
> its ECN bits. Otherwise we might read garbage.
> One symptom is the system erroneously logging errors like
> "vxlan: non-ECT from xxx.xxx.xxx.xxx with TOS=xxxx".
> 
> Similar bugs have been fixed in geneve, ip_tunnel and ip6_tunnel (see
> commit 1ca1ba465e55 ("geneve: make sure to pull inner header in
> geneve_rx()") for example). So let's reuse the same code structure for
> consistency. Maybe we'll can add a common helper in the future.
> 
> Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  drivers/net/vxlan/vxlan_core.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>