netdev - RE: [PATCH v2 1/2] e1000e: let the sleep codes run every time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089D44A4EBA6CA829A23D8AD61F2@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Fri, 3 May 2024 18:17:00 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Ricky Wu <en-wei.wu@...onical.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rickywu0421@...il.com"
	<rickywu0421@...il.com>
Subject: RE: [PATCH v2 1/2] e1000e: let the sleep codes run every time



> -----Original Message-----
> From: Ricky Wu <en-wei.wu@...onical.com>
> Sent: Friday, May 3, 2024 3:18 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; intel-wired-
> lan@...ts.osuosl.org; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; rickywu0421@...il.com; en-wei.wu@...onical.com
> Subject: [PATCH v2 1/2] e1000e: let the sleep codes run every time
> 
> Originally, the sleep codes being moved forward only
> ran if we met some conditions (e.g. BMSR_LSTATUS bit
> not set in phy_status). Moving these sleep codes forward
> makes the usec_interval take effect every time.
> 
> Signed-off-by: Ricky Wu <en-wei.wu@...onical.com>

What's the goal here? Do we need to sleep before initially checking the state?