| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4a2154ccbf8e0e73f09e717d49864eb1003d5cfa.camel@oracle.com>
Date: Fri, 3 May 2024 02:27:22 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "kadlec@...filter.org" <kadlec@...filter.org>,
"dsahern@...nel.org"
<dsahern@...nel.org>,
"tonylu@...ux.alibaba.com" <tonylu@...ux.alibaba.com>,
"mcgrof@...nel.org" <mcgrof@...nel.org>, "fw@...len.de" <fw@...len.de>,
"davem@...emloft.net" <davem@...emloft.net>,
"matttbe@...nel.org"
<matttbe@...nel.org>,
"anna@...nel.org" <anna@...nel.org>,
"trond.myklebust@...merspace.com" <trond.myklebust@...merspace.com>,
"tom@...pey.com" <tom@...pey.com>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"ms@....tdt.de" <ms@....tdt.de>,
"stefan@...enfreihafen.org"
<stefan@...enfreihafen.org>,
"lucien.xin@...il.com" <lucien.xin@...il.com>,
"ying.xue@...driver.com" <ying.xue@...driver.com>,
"steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
"marc.dionne@...istor.com" <marc.dionne@...istor.com>,
"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
"geliang@...nel.org" <geliang@...nel.org>,
"ralf@...ux-mips.org"
<ralf@...ux-mips.org>,
"dhowells@...hat.com" <dhowells@...hat.com>,
"kuba@...nel.org" <kuba@...nel.org>, Dai Ngo <dai.ngo@...cle.com>,
"jmaloy@...hat.com" <jmaloy@...hat.com>,
"alex.aring@...il.com"
<alex.aring@...il.com>,
"ja@....bg" <ja@....bg>, "pablo@...filter.org"
<pablo@...filter.org>,
"horms@...ge.net.au" <horms@...ge.net.au>,
"j.granados@...sung.com" <j.granados@...sung.com>,
"kolga@...app.com"
<kolga@...app.com>,
"courmisch@...il.com" <courmisch@...il.com>,
"keescook@...omium.org" <keescook@...omium.org>,
"martineau@...nel.org"
<martineau@...nel.org>,
"roopa@...dia.com" <roopa@...dia.com>,
"wenjia@...ux.ibm.com" <wenjia@...ux.ibm.com>,
"edumazet@...gle.com"
<edumazet@...gle.com>,
"razor@...ckwall.org" <razor@...ckwall.org>,
"jaka@...ux.ibm.com" <jaka@...ux.ibm.com>,
"jreuter@...na.de"
<jreuter@...na.de>,
"guwen@...ux.alibaba.com" <guwen@...ux.alibaba.com>,
"miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
"jlayton@...nel.org"
<jlayton@...nel.org>,
"marcelo.leitner@...il.com"
<marcelo.leitner@...il.com>,
Chuck Lever III <chuck.lever@...cle.com>,
"neilb@...e.de" <neilb@...e.de>,
"alibuda@...ux.alibaba.com"
<alibuda@...ux.alibaba.com>
CC: "tipc-discussion@...ts.sourceforge.net"
<tipc-discussion@...ts.sourceforge.net>,
"bridge@...ts.linux.dev"
<bridge@...ts.linux.dev>,
"rds-devel@....oracle.com"
<rds-devel@....oracle.com>,
"netfilter-devel@...r.kernel.org"
<netfilter-devel@...r.kernel.org>,
"linux-sctp@...r.kernel.org"
<linux-sctp@...r.kernel.org>,
"dccp@...r.kernel.org" <dccp@...r.kernel.org>,
"coreteam@...filter.org" <coreteam@...filter.org>,
"linux-hams@...r.kernel.org" <linux-hams@...r.kernel.org>,
"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-x25@...r.kernel.org" <linux-x25@...r.kernel.org>,
"lvs-devel@...r.kernel.org" <lvs-devel@...r.kernel.org>,
"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
"linux-afs@...ts.infradead.org" <linux-afs@...ts.infradead.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-wpan@...r.kernel.org" <linux-wpan@...r.kernel.org>,
"mptcp@...ts.linux.dev" <mptcp@...ts.linux.dev>
Subject: Re: [PATCH net-next v6 3/8] net: rds: Remove the now superfluous
sentinel elements from ctl_table array
On Wed, 2024-05-01 at 11:29 +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@...sung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/
> )
>
> * Remove sentinel element from ctl_table structs.
>
> Signed-off-by: Joel Granados <j.granados@...sung.com>
These changes look fine to me. Thank you!
Acked-by: Allison Henderson <allison.henderson@...cle.com>
> ---
> net/rds/ib_sysctl.c | 1 -
> net/rds/sysctl.c | 1 -
> net/rds/tcp.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c
> index e4e41b3afce7..2af678e71e3c 100644
> --- a/net/rds/ib_sysctl.c
> +++ b/net/rds/ib_sysctl.c
> @@ -103,7 +103,6 @@ static struct ctl_table rds_ib_sysctl_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - { }
> };
>
> void rds_ib_sysctl_exit(void)
> diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c
> index e381bbcd9cc1..025f518a4349 100644
> --- a/net/rds/sysctl.c
> +++ b/net/rds/sysctl.c
> @@ -89,7 +89,6 @@ static struct ctl_table rds_sysctl_rds_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - { }
> };
>
> void rds_sysctl_exit(void)
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index 2dba7505b414..d8111ac83bb6 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -86,7 +86,6 @@ static struct ctl_table rds_tcp_sysctl_table[] = {
> .proc_handler = rds_tcp_skbuf_handler,
> .extra1 = &rds_tcp_min_rcvbuf,
> },
> - { }
> };
>
> u32 rds_tcp_write_seq(struct rds_tcp_connection *tc)
>
Powered by blists - more mailing lists