netdev - Re: [net-next] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 6 May 2024 19:43:55 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Andrew Lunn <andrew@...n.ch>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN

Hi Niklas,

On Mon, May 6, 2024 at 4:05 PM Niklas Söderlund
<niklas.soderlund+renesas@...natech.se> wrote:
> On 2024-05-06 03:51:45 +0200, Andrew Lunn wrote:
> > What PHY is this? Does it have C22 registers? Can it be identified via
> > C22 registers 2 and 3?
>
> The PHY in question is mv88q2110 (drivers/net/phy/marvell-88q2xxx.c),
> unfortunately I do not have a datasheet for it so I can't tell you much
> about it.
>
> <snip>
>
> >
> > So i would drop the compatible. See if C22 is sufficient to get the
> > correct driver loaded.
>
> - Remove C45 compatible; Remove C45 read/write in driver
>
>   The PHY is identified as "Generic PHY", and the correct PHY driver is
>   not used. I can't test more than that as the generic PHY driver do not
>   implement some quirks I need to get the link up.
>
> - Remove C45 compatible; Keep C45 read/write in driver
>
>   The correct PHY driver is used and everything works.

Does it still work after kexec, or after device unbind/rebind?
According to [1], the PHY node has a reset-gpios property, so you may
need to specify the exact PHY model to identify the PHY model at any
time, regardless of the state of the PHY reset line.

Perhaps that issue does not happen when using the mdio subnode, cfr. [3]?

[1] https://lore.kernel.org/all/20240122160441.759620-3-niklas.soderlund+renesas@ragnatech.se/
[2] 722d55f3a9bd810f ("arm64: dts: renesas: Add compatible properties
to KSZ9031Ethernet PHYs")
[3] 8da891720cd407ed ("dt-bindings: net: renesas,ethertsn: Create
child-node for MDIO bus") in net-next (next-20240405 and later).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds