netdev - Re: [PATCH iwl-net] i40e: Fix repeated EEH reports in MSI domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 6 May 2024 16:22:04 -0500
From: Thinh Tran <thinhtr@...ux.ibm.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org,
        kuba@...nel.org, anthony.l.nguyen@...el.com,
        aleksandr.loktionov@...el.com
Cc: jesse.brandeburg@...el.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org,
        Robert Thomas <rob.thomas@....com>
Subject: Re: [PATCH iwl-net] i40e: Fix repeated EEH reports in MSI domain


On 5/6/2024 4:35 AM, Przemek Kitszel wrote:


> In general do not add a blank line after Fixes tag.
> Someone could complain that i40e driver had a bug prior to the cited
> core commit, but for more practical purposes I find it good as is.
> When you are a sender of the patch, it's good to place your Signed-off
> as a last tag.

> 
> I appreciate your effort to minimize changed lines to have a fix better
> visible, however we avoid forward declarations in .c files.
> I would split this into two commits - the first to just factor out/move
> functions w/o functional changes, then second one with a logic fix.
> 

Thanks for the review.
I'll correct the typos and resubmit with two separate commits .

Thinh Tran