netdev - Re: [PATCH net-next v4 1/6] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 08 May 2024 16:36:18 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: kuba@...nel.org
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 jiri@...nulli.us, horms@...nel.org
Subject: Re: [PATCH net-next v4 1/6] net: tn40xx: add pci driver for Tehuti
 Networks TN40xx chips

Hi,

On Mon, 6 May 2024 18:38:25 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Thu,  2 May 2024 08:05:47 +0900 FUJITA Tomonori wrote:
>> +	if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
>> +		ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> 
> This fallback is unnecessary, please see commit f0ed939b6a or one of
> many similar removals..

I see, fixed.

It might not be necessary to check the returned value here? I keep the
checking alone like the majority of drivers though.