[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240508110310.GC1385281@ragnatech.se>
Date: Wed, 8 May 2024 13:03:10 +0200
From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
To: Andrew Lunn <andrew@...n.ch>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas
Ethernet-TSN
On 2024-05-08 02:52:18 +0200, Andrew Lunn wrote:
> > +static int rtsn_probe(struct platform_device *pdev)
> > +{
> > + struct rtsn_private *priv;
> > + struct net_device *ndev;
> > + struct resource *res;
> > + int ret;
> > +
> > + ndev = alloc_etherdev_mqs(sizeof(struct rtsn_private), TX_NUM_CHAINS,
>
> ...
>
> > + ether_setup(ndev);
>
> struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs,
> unsigned int rxqs)
> {
> return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_ENUM,
> ether_setup, txqs, rxqs);
> }
>
> Notice the ether_setup here? I think you end up calling it twice.
Indeed, I completely missed that. Thanks for pointing it out, will fix
for next version.
>
> Andrew
--
Kind Regards,
Niklas Söderlund
Powered by blists - more mailing lists