netdev - Re: [PATCH net] e1000e: move force SMBUS near the end of enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71001a25-34f1-48ea-b35b-049ee35335c1@canonical.com>
Date: Wed, 8 May 2024 19:53:04 +0800
From: Hui Wang <hui.wang@...onical.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, sasha.neftin@...el.com, dima.ruinskiy@...el.com,
 Vitaly Lifshits <vitaly.lifshits@...el.com>,
 Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net] e1000e: move force SMBUS near the end of enable_ulp
 function


On 5/8/24 10:21, Jakub Kicinski wrote:
> On Mon,  6 May 2024 10:22:16 -0700 Tony Nguyen wrote:
>> The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp
>> function to avoid PHY loss issue") introduces a regression on
>> CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the
> Referring to the quoted commit as "this commit" is pretty confusing.
>
Will change it in the v2.
>> ethernet works well after suspend and resume, but after applying the
>> commit, the ethernet couldn't work anymore after the resume and the
>> dmesg shows that the NIC Link changes to 10Mbps (1000Mbps originally):
>> [   43.305084] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 10 Mbps Full Duplex, Flow Control: Rx/Tx
>>   release:
>> +	/* Switching PHY interface always returns MDI error
>> +	 * so disable retry mechanism to avoid wasting time
>> +	 */
>> +	e1000e_disable_phy_retry(hw);
>> +
>> +	/* Force SMBus mode in PHY */
>> +	ret_val = e1000_read_phy_reg_hv_locked(hw, CV_SMB_CTRL, &phy_reg);
>> +	if (ret_val)
>> +		goto release;
> Looks like an infinite loop waiting to happen.

Correct, will fix it in the v2.

Thanks.