[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240507192112.3c3ee4f2@kernel.org>
Date: Tue, 7 May 2024 19:21:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
netdev@...r.kernel.org, Hui Wang <hui.wang@...onical.com>,
sasha.neftin@...el.com, dima.ruinskiy@...el.com, Vitaly Lifshits
<vitaly.lifshits@...el.com>, Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net] e1000e: move force SMBUS near the end of enable_ulp
function
On Mon, 6 May 2024 10:22:16 -0700 Tony Nguyen wrote:
> The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp
> function to avoid PHY loss issue") introduces a regression on
> CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the
Referring to the quoted commit as "this commit" is pretty confusing.
> ethernet works well after suspend and resume, but after applying the
> commit, the ethernet couldn't work anymore after the resume and the
> dmesg shows that the NIC Link changes to 10Mbps (1000Mbps originally):
> [ 43.305084] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 10 Mbps Full Duplex, Flow Control: Rx/Tx
> release:
> + /* Switching PHY interface always returns MDI error
> + * so disable retry mechanism to avoid wasting time
> + */
> + e1000e_disable_phy_retry(hw);
> +
> + /* Force SMBus mode in PHY */
> + ret_val = e1000_read_phy_reg_hv_locked(hw, CV_SMB_CTRL, &phy_reg);
> + if (ret_val)
> + goto release;
Looks like an infinite loop waiting to happen.
Powered by blists - more mailing lists