[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4970fd77-504c-4fb3-9c47-e4185d03e74a@lunn.ch>
Date: Wed, 8 May 2024 02:55:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas
Ethernet-TSN
> +static int rtsn_probe(struct platform_device *pdev)
> +{
> + pm_runtime_enable(&pdev->dev);
> + pm_runtime_get_sync(&pdev->dev);
> +static int rtsn_remove(struct platform_device *pdev)
> +{
> + struct rtsn_private *priv = platform_get_drvdata(pdev);
> +
> + unregister_netdev(priv->ndev);
> + rtsn_mdio_free(priv);
> + rcar_gen4_ptp_unregister(priv->ptp_priv);
> + rtsn_change_mode(priv, OCR_OPC_DISABLE);
> + netif_napi_del(&priv->napi);
> +
> + pm_runtime_put_sync(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
These appear to be the only two places you do any pm_ stuff. So it
seems pointless. Maybe delete this for the moment, and come back later
to add proper runtime power management?
Andrew
Powered by blists - more mailing lists