netdev - Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e10ff86-902d-45ed-8671-6544ac4b3930@web.de>
Date: Wed, 8 May 2024 16:09:00 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jeroen de Borst <jeroendb@...gle.com>, Ziwei Xiao <ziweixiao@...gle.com>,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Willem de Bruijn <willemb@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, John Fraker <jfraker@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Shailend Chand <shailend@...gle.com>, rushilg@...gle.com
Subject: Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support

…
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
…
> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
> +{
> +	struct gve_priv *priv = netdev_priv(netdev);
> +	int err = 0;
> +
> +	dev_hold(netdev);
> +	rtnl_unlock();
…
> +out:
> +	rtnl_lock();
> +	dev_put(netdev);
> +	return err;
> +}
…

How do you think about to increase the application of scope-based resource management
at such source code places?

Regards,
Markus