netdev - Re: [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt moderation update action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 7 May 2024 19:31:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
 "Woodhouse, David" <dwmw@...zon.com>, "Machulsky, Zorik"
 <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, Saeed
 Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori,
 Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>,
 "Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali"
 <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>,
 "Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam"
 <ndagan@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Itzko, Shahar"
 <itzko@...zon.com>, "Abboud, Osama" <osamaabb@...zon.com>, "Ostrovsky,
 Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>
Subject: Re: [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt
 moderation update action

On Mon, 6 May 2024 07:04:53 +0000 darinzon@...zon.com wrote:
> +	for (i = 0; i < adapter->num_io_queues; i++) {
> +		adapter->rx_ring[i].interrupt_interval_changed =

Shouldn't this be |= ?

> +			adapter->rx_ring[i].interrupt_interval != val;
> +		adapter->rx_ring[i].interrupt_interval = val;
> +	}