[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240507193302.440feb6e@kernel.org>
Date: Tue, 7 May 2024 19:33:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
"Woodhouse, David" <dwmw@...zon.com>, "Machulsky, Zorik"
<zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, Saeed
Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori,
Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>,
"Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali"
<alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>,
"Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam"
<ndagan@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Itzko, Shahar"
<itzko@...zon.com>, "Abboud, Osama" <osamaabb@...zon.com>, "Ostrovsky,
Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>
Subject: Re: [PATCH v1 net-next 3/6] net: ena: Add validation for completion
descriptors consistency
On Mon, 6 May 2024 07:04:50 +0000 darinzon@...zon.com wrote:
> + if (unlikely((status & ENA_ETH_IO_RX_CDESC_BASE_FIRST_MASK) >>
> + ENA_ETH_IO_RX_CDESC_BASE_FIRST_SHIFT && count != 0)) {
> + struct ena_com_dev *dev = ena_com_io_cq_to_ena_dev(io_cq);
> +
> + netdev_err(dev->net_device,
> + "First bit is on in descriptor #%d on q_id: %d, req_id: %u\n",
> + count, io_cq->qid, cdesc->req_id);
> + return -EFAULT;
This is really asking to be a devlink health reporter.
You can dump the information to the user and get the event counter
for free.
But if you don't want to use that - please at least rate limit the
message.
Powered by blists - more mailing lists