netdev - Re: [PATCH net] eth: sungem: remove .ndo_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240509115133.4fe77b2b@kernel.org>
Date: Thu, 9 May 2024 11:51:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, Erhard Furtner
 <erhard_f@...lbox.org>, "robh@...nel.org" <robh@...nel.org>,
 "elder@...nel.org" <elder@...nel.org>, "bhupesh.sharma@...aro.org"
 <bhupesh.sharma@...aro.org>, "benh@...nel.crashing.org"
 <benh@...nel.crashing.org>
Subject: Re: [PATCH net] eth: sungem: remove .ndo_poll_controller to avoid
 deadlocks

On Thu, 9 May 2024 11:10:46 +0000 Wei Fang wrote:
> Thanks for reminder.
> The fec driver should have the same issue, but I don't know much about netpoll,
> is ndo_poll_controller() no needed anymore? so it can be safely deleted from
> device driver?

If the driver uses NAPI for tx completions - implementing
ndo_poll_controller is not necessary.