netdev - Re: [PATCH net] eth: sungem: remove .ndo_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <171539102901.31003.5030547780750327077.git-patchwork-notify@kernel.org>
Date: Sat, 11 May 2024 01:30:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, erhard_f@...lbox.org, robh@...nel.org, elder@...nel.org,
 wei.fang@....com, bhupesh.sharma@...aro.org, benh@...nel.crashing.org
Subject: Re: [PATCH net] eth: sungem: remove .ndo_poll_controller to avoid
 deadlocks

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  8 May 2024 06:45:04 -0700 you wrote:
> Erhard reports netpoll warnings from sungem:
> 
>   netpoll_send_skb_on_dev(): eth0 enabled interrupts in poll (gem_start_xmit+0x0/0x398)
>   WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c
> 
> gem_poll_controller() disables interrupts, which may sleep.
> We can't sleep in netpoll, it has interrupts disabled completely.
> Strangely, gem_poll_controller() doesn't even poll the completions,
> and instead acts as if an interrupt has fired so it just schedules
> NAPI and exits. None of this has been necessary for years, since
> netpoll invokes NAPI directly.
> 
> [...]

Here is the summary with links:
  - [net] eth: sungem: remove .ndo_poll_controller to avoid deadlocks
    https://git.kernel.org/netdev/net/c/ac0a230f719b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html