netdev - Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1715531818.6973832-3-hengqi@linux.alibaba.com>
Date: Mon, 13 May 2024 00:36:58 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: kernel test robot <lkp@...el.com>
Cc: llvm@...ts.linux.dev,
 oe-kbuild-all@...ts.linux.dev,
 Jakub Kicinski <kuba@...nel.org>,
 "David S . Miller" <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Jason Wang <jasowang@...hat.com>,
 "Michael S . Tsirkin" <mst@...hat.com>,
 Brett Creeley <bcreeley@....com>,
 Ratheesh Kannoth <rkannoth@...vell.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Tal Gilboa <talgi@...dia.com>,
 Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Paul Greenwalt <paul.greenwalt@...el.com>,
 Ahmed Zaki <ahmed.zaki@...el.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Andrew Lunn <andrew@...n.ch>,
 justinstitt@...gle.com,
 donald.hunter@...il.com,
 netdev@...r.kernel.org,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

On Fri, 10 May 2024 07:09:52 +0800, kernel test robot <lkp@...el.com> wrote:
> Hi Heng,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on net-next/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240509-125007
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20240509044747.101237-3-hengqi%40linux.alibaba.com
> patch subject: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management
> config: arm-randconfig-002-20240510 (https://download.01.org/0day-ci/archive/20240510/202405100654.5PbLQXnL-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project b910bebc300dafb30569cecc3017b446ea8eafa0)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405100654.5PbLQXnL-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405100654.5PbLQXnL-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> ld.lld: error: undefined symbol: lockdep_rtnl_is_held

This failed use case seems to come from this series triggering a problem that
has not been triggered historically, namely lockdep_rtnl_is_held() is not called
in an environment where CONFIG_NET is not configured and CONFIG_PROVE_LOCKING is
configured:
  If CONFIG_PROVE_LOCKING is configured as Y and CONFIG_NET is n, then
  lockdep_rtnl_is_held is in an undefined state at this time.

So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET".
How do you think?

Thanks!

>    >>> referenced by net_dim.c
>    >>>               lib/dim/net_dim.o:(net_dim_free_irq_moder) in archive vmlinux.a
>    >>> referenced by net_dim.c
>    >>>               lib/dim/net_dim.o:(net_dim_free_irq_moder) in archive vmlinux.a
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki