[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240513072249.7b0513b0@kernel.org>
Date: Mon, 13 May 2024 07:22:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Heng Qi <hengqi@...ux.alibaba.com>
Cc: kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
oe-kbuild-all@...ts.linux.dev, "David S . Miller" <davem@...emloft.net>,
Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, Jason
Wang <jasowang@...hat.com>, "Michael S . Tsirkin" <mst@...hat.com>, Brett
Creeley <bcreeley@....com>, Ratheesh Kannoth <rkannoth@...vell.com>,
Alexander Lobakin <aleksander.lobakin@...el.com>, Xuan Zhuo
<xuanzhuo@...ux.alibaba.com>, Tal Gilboa <talgi@...dia.com>, Jonathan
Corbet <corbet@....net>, linux-doc@...r.kernel.org, Maxime Chevallier
<maxime.chevallier@...tlin.com>, Jiri Pirko <jiri@...nulli.us>, Paul
Greenwalt <paul.greenwalt@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
Vladimir Oltean <vladimir.oltean@....com>, Kory Maincent
<kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
justinstitt@...gle.com, donald.hunter@...il.com, netdev@...r.kernel.org,
virtualization@...ts.linux.dev
Subject: Re: [PATCH net-next v13 2/4] ethtool: provide customized dim
profile management
On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote:
> This failed use case seems to come from this series triggering a problem that
> has not been triggered historically, namely lockdep_rtnl_is_held() is not called
> in an environment where CONFIG_NET is not configured and CONFIG_PROVE_LOCKING is
> configured:
> If CONFIG_PROVE_LOCKING is configured as Y and CONFIG_NET is n, then
> lockdep_rtnl_is_held is in an undefined state at this time.
>
> So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET".
> How do you think?
Doesn't sound right, can we instead make building lib/dim/net_dim.c
dependent on CONFIG_NET? Untested but I'm thinking something like:
diff --git a/lib/dim/Makefile b/lib/dim/Makefile
index c4cc4026c451..c02c306e2975 100644
--- a/lib/dim/Makefile
+++ b/lib/dim/Makefile
@@ -4,4 +4,8 @@
obj-$(CONFIG_DIMLIB) += dimlib.o
-dimlib-objs := dim.o net_dim.o rdma_dim.o
+dimlib-objs := dim.o rdma_dim.o
+
+ifeq ($(CONFIG_NET),y)
+dimlib-objs += net_dim.o
+endif
Powered by blists - more mailing lists