netdev - Re: [PATCH 12/17] irqchip: Add support for LAN966x OIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240513145049.25695b4a@bootlin.com>
Date: Mon, 13 May 2024 14:50:49 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: <Steen.Hegelund@...rochip.com>
Cc: <tglx@...utronix.de>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <kuba@...nel.org>, <pabeni@...hat.com>, <lee@...nel.org>, <arnd@...db.de>,
 <Horatiu.Vultur@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
 <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
 <saravanak@...gle.com>, <bhelgaas@...gle.com>, <p.zabel@...gutronix.de>,
 <Lars.Povlsen@...rochip.com>, <Daniel.Machon@...rochip.com>,
 <alexandre.belloni@...tlin.com>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
 <linux-pci@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <Allan.Nielsen@...rochip.com>, <luca.ceresoli@...tlin.com>,
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 12/17] irqchip: Add support for LAN966x OIC

Hi Steen,

On Wed, 8 May 2024 08:08:30 +0000
<Steen.Hegelund@...rochip.com> wrote:

...
> > +/* Mapping of source to destination interrupts (_n = 0..8) */  
> 
> Are the indices really needed on LAN966X_OIC_DST_INTR_MAP* and _IDENT*
> You do not appear to be using them?
> 
> 
> > +#define LAN966X_OIC_DST_INTR_MAP(_n)   0x78

Indeed, I missed them.
These registers are defined from 0 to 8 in the document:
  https://microchip-ung.github.io/lan9662_reginfo/reginfo_LAN9662.html?select=cpu,intr

The code use only the indice 0.
In the next iteration, I will keep indices and update the definition of
registers like that:
  #define LAN966X_OIC_DST_INTR_MAP(_n)   (0x78 + (_n) * 4)

Best regards
Hervé