[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240513145358.GA2574205-robh@kernel.org>
Date: Mon, 13 May 2024 09:53:58 -0500
From: Rob Herring <robh@...nel.org>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Lee Jones <lee@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Saravana Kannan <saravanak@...gle.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Steen Hegelund <Steen.Hegelund@...rochip.com>,
Daniel Machon <daniel.machon@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
netdev@...r.kernel.org, linux-pci@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Allan Nielsen <allan.nielsen@...rochip.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 09/17] dt-bindings: interrupt-controller: Add support for
Microchip LAN966x OIC
On Mon, May 13, 2024 at 02:37:20PM +0200, Herve Codina wrote:
> Hi Rob,
>
> On Tue, 7 May 2024 10:28:06 -0500
> Rob Herring <robh@...nel.org> wrote:
>
> ...
> > > +examples:
> > > + - |
> > > + interrupt-controller@...c0120 {
> > > + compatible = "microchip,lan966x-oic";
> > > + reg = <0xe00c0120 0x190>;
> >
> > Looks like this is part of some larger block?
> >
>
> According to the registers information document:
> https://microchip-ung.github.io/lan9662_reginfo/reginfo_LAN9662.html?select=cpu,intr
>
> The interrupt controller is mapped at offset 0x48 (offset in number of
> 32bit words).
> -> Address offset: 0x48 * 4 = 0x120
> -> size: (0x63 + 1) * 4 = 0x190
>
> IMHO, the reg property value looks correct.
What I mean is h/w blocks don't just start at some address with small
alignment. That wouldn't work from a physical design standpoint. The
larger block here is "CPU System Regs". The block as a whole should be
documented, but maybe that ship already sailed.
Also, here you call it the OIC, but the link above calls it the VCore
interrupt controller.
Rob
Powered by blists - more mailing lists