netdev - Re: [PATCH bpf-next v2 2/4] netfilter: add bpf_xdp_flow_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP01T77rCZjM_G2-dntw=GN9rXZB_58H8YUwjGJskvTzd7MT5g@mail.gmail.com>
Date: Sat, 18 May 2024 23:50:29 +0200
From: Kumar Kartikeya Dwivedi <memxor@...il.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: bpf@...r.kernel.org, pablo@...filter.org, kadlec@...filter.org, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org, 
	daniel@...earbox.net, andrii@...nel.org, lorenzo.bianconi@...hat.com, 
	toke@...hat.com, fw@...len.de, hawk@...nel.org, horms@...nel.org, 
	donhunte@...hat.com
Subject: Re: [PATCH bpf-next v2 2/4] netfilter: add bpf_xdp_flow_offload_lookup
 kfunc

On Sat, 18 May 2024 at 12:13, Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Introduce bpf_xdp_flow_offload_lookup kfunc in order to perform the
> lookup of a given flowtable entry based on a fib tuple of incoming
> traffic.
> bpf_xdp_flow_offload_lookup can be used as building block to offload
> in xdp the processing of sw flowtable when hw flowtable is not
> available.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---

Acked-by: Kumar Kartikeya Dwivedi <memxor@...il.com>

Though I think it might have been better to have an opts parameter for
extensibility (and have opts->error for now to aid debugging when NULL
is returned),
but I won't insist (it's not a big deal, as there's only two things
that can go wrong: the tuple->family is unsupported or the lookup
fails).