netdev - Re: [PATCH] net: set struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c1dd2da-9541-4d9c-a302-0a961862cedd@lunn.ch>
Date: Sun, 19 May 2024 00:04:05 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: set struct net_device::name earlier

On Sat, May 18, 2024 at 11:24:57PM +0300, Alexey Dobriyan wrote:
> I've tried debugging networking allocations with bpftrace and doing
> 
> 	$dev = (struct net_device*)arg0;
> 	printf("dev %s\n", $dev->name);
> 
> doesn't print anything useful in functions called right after netdevice
> allocation. The reason is very simple: dev->name has not been set yet.
> 
> Make name copying much earlier for smoother debugging experience.

Does this really help? Instead of "" don't you get "eth%d"? The
expansion of the %d to eth42 does not happen until you register the
netdev.

	Andrew