[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <C9B198E3-1E73-4F17-8A35-CB9312C9CF1F@oracle.com>
Date: Tue, 21 May 2024 14:02:37 +0000
From: Haakon Bugge <haakon.bugge@...cle.com>
To: Tejun Heo <tj@...nel.org>
CC: OFED mailing list <linux-rdma@...r.kernel.org>,
open list
<linux-kernel@...r.kernel.org>,
netdev <netdev@...r.kernel.org>,
"rds-devel@....oracle.com" <rds-devel@....oracle.com>,
Jason Gunthorpe
<jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
Saeed Mahameed
<saeedm@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
"David S . Miller"
<davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Lai Jiangshan
<jiangshanlai@...il.com>,
Allison Henderson <allison.henderson@...cle.com>,
Manjunath Patil <manjunath.b.patil@...cle.com>,
Mark Zhang
<markzhang@...dia.com>,
Chuck Lever III <chuck.lever@...cle.com>,
Shiraz
Saleem <shiraz.saleem@...el.com>,
Yang Li <yang.lee@...ux.alibaba.com>
Subject: Re: [PATCH v2 1/6] workqueue: Inherit NOIO and NOFS alloc flags
Hi,
> On 16 May 2024, at 18:29, Tejun Heo <tj@...nel.org> wrote:
>
>
>> When you say "deal with gfp flags directly", do you imply during WQ
>> creation or queuing work on one? I am OK with adding the other per-process
>> memory allocation flags, but that doesn's solve your initial issue ("if a
>> NOIO callers wants to scheduler a work item so that it can user
>> GFP_KERNEL").
>
> It being a purely convenience feature, I don't think there's hard
> requirement on where this should go although I don't know where you'd carry
> this information if you tied it to each work item. And, please don't single
> out specific GFP flags. Please make the feature generic so that users who
> may need different GFP masking can also use it too. The underlying GFP
> feature is already like that. There's no reason to restrict it from
> workqueue side.
I am preparing a v3 which handles all PF_MEMALLOC* flags. The plan is to send it out tomorrow.
Thxs, HÃ¥kon
Powered by blists - more mailing lists