netdev - Re: [PATCH net 7/8] net/mlx5e: Use rx_missed_errors instead of rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240523094842.GJ883722@kernel.org>
Date: Thu, 23 May 2024 10:48:42 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net 7/8] net/mlx5e: Use rx_missed_errors instead of
 rx_dropped for reporting buffer exhaustion

On Wed, May 22, 2024 at 10:26:58PM +0300, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> Previously, the driver incorrectly used rx_dropped to report device
> buffer exhaustion.
> 
> According to the documentation, rx_dropped should not be used to count
> packets dropped due to buffer exhaustion, which is the purpose of
> rx_missed_errors.
> 
> Use rx_missed_errors as intended for counting packets dropped due to
> buffer exhaustion.
> 
> Fixes: 269e6b3af3bf ("net/mlx5e: Report additional error statistics in get stats ndo")
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>