netdev - Re: [PATCH net 8/8] net/mlx5e: Fix UDP GSO for encapsulated packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240523094859.GK883722@kernel.org>
Date: Thu, 23 May 2024 10:48:59 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Jason Baron <jbaron@...mai.com>,
	Dragos Tatulea <dtatulea@...dia.com>,
	Boris Pismenny <borisp@...dia.com>
Subject: Re: [PATCH net 8/8] net/mlx5e: Fix UDP GSO for encapsulated packets

On Wed, May 22, 2024 at 10:26:59PM +0300, Tariq Toukan wrote:
> From: Gal Pressman <gal@...dia.com>
> 
> When the skb is encapsulated, adjust the inner UDP header instead of the
> outer one, and account for UDP header (instead of TCP) in the inline
> header size calculation.
> 
> Fixes: 689adf0d4892 ("net/mlx5e: Add UDP GSO support")
> Reported-by: Jason Baron <jbaron@...mai.com>
> Closes: https://lore.kernel.org/netdev/c42961cb-50b9-4a9a-bd43-87fe48d88d29@akamai.com/
> Signed-off-by: Gal Pressman <gal@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Boris Pismenny <borisp@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Thanks,

This patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>

While looking over this patch, I noticed that it seems
that a similar pattern to the mlx5e_tx_get_gso_ihs() code
modified here appears in at least the MANA and NFP drivers.
So perhaps we could consider a helper in future.