netdev - Re: [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52077a99395935c60bafb3c81d96fc64dee5261a.camel@redhat.com>
Date: Thu, 23 May 2024 11:53:37 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Mathieu Othacehe <othacehe@....org>, Andrew Lunn <andrew@...n.ch>, 
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Florian
 Fainelli <f.fainelli@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Karim Ben Houcine
	 <karim.benhoucine@...disgyr.com>
Subject: Re: [PATCH] net: phy: micrel: set soft_reset callback to
 genphy_soft_reset for KSZ8061

On Tue, 2024-05-21 at 08:54 +0200, Mathieu Othacehe wrote:
> Following a similar reinstate for the KSZ8081 and KSZ9031.
> 
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
> 
> The KSZ8061 errata described here:
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
> and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
> is back again without this soft reset.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Tested-by: Karim Ben Houcine <karim.benhoucine@...disgyr.com>
> Signed-off-by: Mathieu Othacehe <othacehe@....org>

LGTM, but waiting a little longer for anyone from phy crew to ack it.

Thanks,

Paolo