netdev - RE: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508916EC8EF80A8EFE6EF19DD6F12@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Tue, 28 May 2024 23:54:21 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
 SIOCSHWTSTAMP and SIOCGHWTSTAMP



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, May 28, 2024 1:01 PM
> To: Polchlopek, Mateusz <mateusz.polchlopek@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; Drewek, Wojciech <wojciech.drewek@...el.com>;
> Rahul Rameshbabu <rrameshbabu@...dia.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
> SIOCSHWTSTAMP and SIOCGHWTSTAMP
> 
> On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
> > +	.ndo_eth_ioctl		= iavf_do_ioctl,
> 
> Please use the new ndos:
> 
>  * int (*ndo_hwtstamp_get)(struct net_device *dev,
>  *			   struct kernel_hwtstamp_config *kernel_config);
>  *	Get the currently configured hardware timestamping parameters for the
>  *	NIC device.
>  *
>  * int (*ndo_hwtstamp_set)(struct net_device *dev,
>  *			   struct kernel_hwtstamp_config *kernel_config,
>  *			   struct netlink_ext_ack *extack);
>  *	Change the hardware timestamping parameters for NIC device.

+1, this is an excellent cleanup.

Thanks,
Jake