netdev - Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 29 May 2024 15:12:09 +0200
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, Jakub Kicinski
	<kuba@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
 SIOCSHWTSTAMP and SIOCGHWTSTAMP

On 5/29/2024 1:54 AM, Keller, Jacob E wrote:
> 
> 
>> -----Original Message-----
>> From: Jakub Kicinski <kuba@...nel.org>
>> Sent: Tuesday, May 28, 2024 1:01 PM
>> To: Polchlopek, Mateusz <mateusz.polchlopek@...el.com>
>> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Keller, Jacob E
>> <jacob.e.keller@...el.com>; Drewek, Wojciech <wojciech.drewek@...el.com>;
>> Rahul Rameshbabu <rrameshbabu@...dia.com>
>> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
>> SIOCSHWTSTAMP and SIOCGHWTSTAMP
>>
>> On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
>>> +	.ndo_eth_ioctl		= iavf_do_ioctl,
>>
>> Please use the new ndos:
>>
>>   * int (*ndo_hwtstamp_get)(struct net_device *dev,
>>   *			   struct kernel_hwtstamp_config *kernel_config);
>>   *	Get the currently configured hardware timestamping parameters for the
>>   *	NIC device.
>>   *
>>   * int (*ndo_hwtstamp_set)(struct net_device *dev,
>>   *			   struct kernel_hwtstamp_config *kernel_config,
>>   *			   struct netlink_ext_ack *extack);
>>   *	Change the hardware timestamping parameters for NIC device.
> 
> +1, this is an excellent cleanup.
> 
> Thanks,
> Jake

Hmmm... sounds good :) Thanks for pointing that, I will take a look
and will try to prepare solution in next version