netdev - Re: [PATCH net] ipv4: correctly iterate over the target netns in inet_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEivzxccCgT17u45c3fRG4=+X-rxLz04L8+B5B4GD=weA5khmQ@mail.gmail.com>
Date: Wed, 29 May 2024 10:52:48 +0200
From: Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Christian Brauner <brauner@...nel.org>, kuba@...nel.org, dsahern@...nel.org, 
	pabeni@...hat.com, stgraber@...raber.org, davem@...emloft.net, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ipv4: correctly iterate over the target netns in inet_dump_ifaddr()

On Wed, May 29, 2024 at 10:29 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Wed, May 29, 2024 at 9:49 AM Christian Brauner <brauner@...nel.org> wrote:
> >
> > On Tue, May 28, 2024 at 10:30:30PM +0200, Alexander Mikhalitsyn wrote:
> > > A recent change to inet_dump_ifaddr had the function incorrectly iterate
> > > over net rather than tgt_net, resulting in the data coming for the
> > > incorrect network namespace.
> > >
> > > Fixes: cdb2f80f1c10 ("inet: use xa_array iterator to implement inet_dump_ifaddr()")
> > > Reported-by: Stéphane Graber <stgraber@...raber.org>
> > > Closes: https://github.com/lxc/incus/issues/892
> > > Bisected-by: Stéphane Graber <stgraber@...raber.org>
> > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
> > > Tested-by: Stéphane Graber <stgraber@...raber.org>
> > > ---
> >
> > Acked-by: Christian Brauner <brauner@...nel.org>
>
> Thanks a lot for the bisection and the fix !

Thanks, Eric!

>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>