netdev - Re: [PATCH net-next v2 0/6] net: stmmac: cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfiqy7q3fb6ybmpszd7ktvuxr3kec4z2ra455pdqjkn6i4fb64@crtsjh4bslim>
Date: Wed, 29 May 2024 12:05:09 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Halaney <ahalaney@...hat.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Jose Abreu <joabreu@...opsys.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-stm32@...md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH net-next v2 0/6] net: stmmac: cleanups

Hi Russell

On Wed, May 29, 2024 at 09:40:15AM +0100, Russell King (Oracle) wrote:
> Hi,
> 
> This series removes various redundant items in the stmmac driver:
> 
> - the unused TBI and RTBI PCS flags
> - the NULL pointer initialisations for PCS methods in dwxgmac2
> - the stmmac_pcs_rane() method which is never called, and it's
>   associated implementations
> - the redundant netif_carrier_off()s
> 
> Finally, it replaces asm/io.h with the preferred linux/io.h.
> 
> Changes since v1:
>  - Fix patch 1 "Drop TBI/RTBI flags" which didn't transfer correctly
>    between my internal trees!
>  - Update patch 5 to address all the asm/io.h in stmmac
>  - Add Andrew Halaney's reviewed-by
>  - Add patch 6 cleaning up qcom-ethqos phy speed setting

Thanks for the series. For all patches:

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

* Note I've got your messages regarding the STMMAC driver and
RGMII/SGMII/etc PCS. I do remember about that and will respond to all
of them either later today or tomorrow. Currently busy with my long
lasting DW XPCS series.

-Serge(y)

> 
>  drivers/net/ethernet/stmicro/stmmac/common.h       |  2 --
>  .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 24 +++++++-------
>  .../net/ethernet/stmicro/stmmac/dwmac1000_core.c   |  8 +----
>  .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c    |  2 +-
>  .../net/ethernet/stmicro/stmmac/dwmac100_core.c    |  2 +-
>  drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c |  2 +-
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c  |  8 -----
>  .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c    |  6 ----
>  drivers/net/ethernet/stmicro/stmmac/hwif.h         |  3 --
>  .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c   |  2 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 38 +++++-----------------
>  drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h   | 17 ----------
>  12 files changed, 26 insertions(+), 88 deletions(-)
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!