netdev - Re: [RFC net-next 14/15] net/mlx5e: Add Rx data path offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75e8b441ace12b028f779163a0980b310ad68504.camel@nvidia.com>
Date: Thu, 30 May 2024 09:04:52 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "kuba@...nel.org" <kuba@...nel.org>, Rahul Rameshbabu
	<rrameshbabu@...dia.com>, Raed Salem <raeds@...dia.com>
CC: "steffen.klassert@...unet.com" <steffen.klassert@...unet.com>, Tariq
 Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>,
	"willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Boris Pismenny
	<borisp@...dia.com>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [RFC net-next 14/15] net/mlx5e: Add Rx data path offload

On Wed, 2024-05-29 at 11:38 -0700, Jakub Kicinski wrote:
> On Sun, 12 May 2024 21:54:38 -0400 Willem de Bruijn wrote:
> > > +	/* TBD: report errors as SW counters to ethtool, any further handling ? */
> > > +	switch (MLX5_NISP_METADATA_SYNDROM(nisp_meta_data)) {
> > > +	case MLX5E_NISP_OFFLOAD_RX_SYNDROME_DECRYPTED:
> > > +		if (psp_rcv(skb))
> > > +			netdev_warn_once(netdev, "PSP handling failed");
> > > +		skb->decrypted = 1;  
> > 
> > Do not set skb->decrypted if psp_rcv failed? But drop the packet and
> > account the drop, likely.
> 
> nVidia folks does this seem reasonable?

This seems reasonable. It's also what the comment above the switch
suggests should be done.
psp_rcv unrefs the skb on errors (doesn't even return error in all
cases) and I think it's no longer safe to touch it, unless there's
another ref held somewhere.

I've tried implementing this tweak in the shared repo we have, but it
seems it doesn't have the versions of this patch that you sent.

Cosmin.