netdev - Re: [PATCH net] netdev: add qstat for csum complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc71647cbb44b37bc4a6d5ce85529039744da87b.camel@redhat.com>
Date: Thu, 30 May 2024 12:15:12 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, donald.hunter@...il.com, 
	sdf@...gle.com, amritha.nambiar@...el.com, hawk@...nel.org, 
	sridhar.samudrala@...el.com, jdamato@...tly.com
Subject: Re: [PATCH net] netdev: add qstat for csum complete

On Wed, 2024-05-29 at 09:35 -0700, Jakub Kicinski wrote:
> Recent commit 0cfe71f45f42 ("netdev: add queue stats") added
> a lot of useful stats, but only those immediately needed by virtio.
> Presumably virtio does not support CHECKSUM_COMPLETE,
> so statistic for that form of checksumming wasn't included.
> Other drivers will definitely need it, in fact we expect it
> to be needed in net-next soon (mlx5). So let's add the definition
> of the counter for CHECKSUM_COMPLETE to uAPI in net already,
> so that the counters are in a more natural order (all subsequent
> counters have not been present in any released kernel, yet).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Given the uAPI implication I believe its better to let this land into
today PR. Also adding

Fixes: 0cfe71f45f42 ("netdev: add queue stats")

To try to reduce the chance that backports will end-up with
inconsistent uAPI.

Cheers,

Paolo