netdev - Re: [PATCH net-next 4/6] net: fman_memac: remove the now unnecessary checking for fixed-link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d77af3f-997a-45cf-873d-79b912a15f72@seco.com>
Date: Thu, 30 May 2024 10:57:43 -0400
From: Sean Anderson <sean.anderson@...o.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Halaney <ahalaney@...hat.com>,
 Serge Semin <fancer.lancer@...il.com>, Madalin Bucur
 <madalin.bucur@....com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/6] net: fman_memac: remove the now unnecessary
 checking for fixed-link

On 5/29/24 09:29, Russell King (Oracle) wrote:
> Since default_an_inband can be overriden by a fixed-link specification,
> there is no need for memac to be checking for this before setting
> default_an_inband. Remove this code and update the comment.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/ethernet/freescale/fman/fman_memac.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index 9c44a3581950..796e6f4e583d 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -1066,7 +1066,6 @@ int memac_initialization(struct mac_device *mac_dev,
>                        struct fman_mac_params *params)
>  {
>       int                      err;
> -     struct device_node      *fixed;
>       struct phylink_pcs      *pcs;
>       struct fman_mac         *memac;
>       unsigned long            capabilities;
> @@ -1222,18 +1221,15 @@ int memac_initialization(struct mac_device *mac_dev,
>               memac->rgmii_no_half_duplex = true;
>
>       /* Most boards should use MLO_AN_INBAND, but existing boards don't have
> -      * a managed property. Default to MLO_AN_INBAND if nothing else is
> -      * specified. We need to be careful and not enable this if we have a
> -      * fixed link or if we are using MII or RGMII, since those
> -      * configurations modes don't use in-band autonegotiation.
> +      * a managed property. Default to MLO_AN_INBAND rather than MLO_AN_PHY.
> +      * Phylink will allow this to be overriden by a fixed link. We need to
> +      * be careful and not enable this if we are using MII or RGMII, since
> +      * those configurations modes don't use in-band autonegotiation.
>        */
> -     fixed = of_get_child_by_name(mac_node, "fixed-link");
> -     if (!fixed && !of_property_read_bool(mac_node, "fixed-link") &&
> -         !of_property_read_bool(mac_node, "managed") &&
> +     if (!of_property_read_bool(mac_node, "managed") &&
>           mac_dev->phy_if != PHY_INTERFACE_MODE_MII &&
>           !phy_interface_mode_is_rgmii(mac_dev->phy_if))
>               mac_dev->phylink_config.default_an_inband = true;
> -     of_node_put(fixed);
>
>       err = memac_init(mac_dev->fman_mac);
>       if (err < 0)

Reviewed-by: Sean Anderson <sean.anderson@...o.com>

[Clea Astarte Google Cloud, SECO SpA]<https://clea.ai/astarte-on-google-cloud>