[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6659d415c8aa3_3f8cab2944d@willemb.c.googlers.com.notmuch>
Date: Fri, 31 May 2024 09:43:49 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>,
edumazet@...gle.com,
pabeni@...hat.com
Cc: davem@...emloft.net,
netdev@...r.kernel.org,
mptcp@...ts.linux.dev,
matttbe@...nel.org,
martineau@...nel.org,
borisp@...dia.com,
willemdebruijn.kernel@...il.com,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 1/3] tcp: wrap mptcp and decrypted checks into
tcp_skb_can_collapse_rx()
Jakub Kicinski wrote:
> tcp_skb_can_collapse() checks for conditions which don't make
> sense on input. Because of this we ended up sprinkling a few
> pairs of mptcp_skb_can_collapse() and skb_cmp_decrypted() calls
> on the input path. Group them in a new helper. This should make
> it less likely that someone will check mptcp and not decrypted
> or vice versa when adding new code.
>
> This implicitly adds a decrypted check early in tcp_collapse().
> AFAIU this will very slightly increase our ability to collapse
> packets under memory pressure, not a real bug.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists