netdev - Re: [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240601145620.065e6a5d@kernel.org>
Date: Sat, 1 Jun 2024 14:56:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: edumazet@...gle.com, pabeni@...hat.com, davem@...emloft.net,
 netdev@...r.kernel.org, mptcp@...ts.linux.dev, matttbe@...nel.org,
 martineau@...nel.org, borisp@...dia.com
Subject: Re: [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail
 skb

On Fri, 31 May 2024 09:41:30 -0400 Willem de Bruijn wrote:
> > +static inline void tcp_write_collapse_fence(struct sock *sk)
> > +{  
> 
> const struct ptr?

Maybe just me, but feels kinda weird for the sole input to be const
if the function does modify the object it operates on.