netdev - Re: [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <665bcc4869dc3_94803294e9@willemb.c.googlers.com.notmuch>
Date: Sat, 01 Jun 2024 21:35:04 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: edumazet@...gle.com, 
 pabeni@...hat.com, 
 davem@...emloft.net, 
 netdev@...r.kernel.org, 
 mptcp@...ts.linux.dev, 
 matttbe@...nel.org, 
 martineau@...nel.org, 
 borisp@...dia.com
Subject: Re: [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail
 skb

Jakub Kicinski wrote:
> On Fri, 31 May 2024 09:41:30 -0400 Willem de Bruijn wrote:
> > > +static inline void tcp_write_collapse_fence(struct sock *sk)
> > > +{  
> > 
> > const struct ptr?
> 
> Maybe just me, but feels kinda weird for the sole input to be const
> if the function does modify the object it operates on.

Ok. I can see that.