netdev - Re: [PATCH net-next v2 00/12] virtnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 31 May 2024 09:57:33 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 virtualization@...ts.linux.dev,
 bpf@...r.kernel.org,
 "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net-next v2 00/12] virtnet_net: prepare for af-xdp

On Thu, 30 May 2024 18:55:17 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Fri, 31 May 2024 09:40:14 +0800 Xuan Zhuo wrote:
> > On Thu, 30 May 2024 19:54:44 +0800, Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
> > > On Thu, 30 May 2024 07:53:17 -0400, "Michael S. Tsirkin" <mst@...hat.com> wrote:
> > > > It's great that you are working on this but
> > > > I'd like to see the actual use of this first.
> > >
> > >
> > > For me, that is easy. But how should we do, if we use one patch set,
> > > then the commit number maybe 26, that exceeds 15 (limit of the net next).
> >
> > Hi, Jakub
> >
> > There will be a huge patch set (about 25) to support AF-XDP for virtio-net.
> > Can I just post this huge patch set if the maintainers of virtio-net agree?
>
> First of all, I see you posted v2 within 4 hours of v1, without really
> waiting for Michael to reply.

Because I was checking the code, I found some commits need to be prepared also.

> So I guess that 15 patch rule is not the
> only one you intend to break?

Actually, that is the only one rule.

>
> On v1 Michael asked you to not do the rename, and start with AF_XDP
> support. Why don't you do that instead of asking me if you can break
> more rules?

Because if I don't rename the files, there will still be about 21 commits. For
me, I don't think this is the key. If I release everything in one patch set,
then I think Michael can understand why I want to rename the files.

Thanks.

> --
> pw-bot: cr