netdev - Re: [PATCH net-next 0/8] Probing cleanup for the Felix DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zlk/GmpxUq/iOqs4@colin-ia-desktop>
Date: Thu, 30 May 2024 22:08:10 -0500
From: Colin Foster <colin.foster@...advantage.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next 0/8] Probing cleanup for the Felix DSA driver

Hi Vladimir,

On Thu, May 30, 2024 at 07:33:25PM +0300, Vladimir Oltean wrote:
> This is a follow-up to Russell King's request for code consolidation
> among felix_vsc9959, seville_vsc9953 and ocelot_ext, stated here:
> https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/
> 
> Details are in individual patches. Testing was done on NXP LS1028A
> (felix_vsc9959).
> 
> Vladimir Oltean (8):
>   net: dsa: ocelot: use devres in ocelot_ext_probe()
>   net: dsa: ocelot: use devres in seville_probe()
>   net: dsa: ocelot: delete open coded status = "disabled" parsing
>   net: dsa: ocelot: consistently use devres in felix_pci_probe()
>   net: dsa: ocelot: move devm_request_threaded_irq() to felix_setup()
>   net: dsa: ocelot: use ds->num_tx_queues = OCELOT_NUM_TC for all models
>   net: dsa: ocelot: common probing code
>   net: dsa: ocelot: unexport felix_phylink_mac_ops and felix_switch_ops
> 
>  drivers/net/dsa/ocelot/felix.c           |  62 ++++++++++++-
>  drivers/net/dsa/ocelot/felix.h           |  10 +-
>  drivers/net/dsa/ocelot/felix_vsc9959.c   | 113 +++++++----------------
>  drivers/net/dsa/ocelot/ocelot_ext.c      |  55 +----------

Just FYI I tried testing this but hit an unrelated regression in 6.10,
and a `git b4` on 6.9.3 has conflicts. So I'm still alive, but probably
won't get to testing this tonight. Looks good though.

Colin Foster