[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9efb0c64-d3b2-478b-953e-94ef8be3ddec@lunn.ch>
Date: Sun, 2 Jun 2024 19:40:45 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, conor@...nel.org,
linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
devicetree@...r.kernel.org, catalin.marinas@....com,
will@...nel.org, upstream@...oha.com,
angelogioacchino.delregno@...labora.com,
benjamin.larsson@...exis.eu
Subject: Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for
EN7581 SoC
> +static void airoha_remove(struct platform_device *pdev)
> +{
> + struct airoha_eth *eth = platform_get_drvdata(pdev);
> + int i;
> +
> + debugfs_remove(eth->debugfs_dir);
> +
> + airoha_qdma_for_each_q_rx(eth, i) {
> + struct airoha_queue *q = ð->q_rx[i];
> +
> + netif_napi_del(&q->napi);
> + airoha_qdma_clenaup_rx_queue(q);
> + page_pool_destroy(q->page_pool);
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
> + netif_napi_del(ð->q_tx_irq[i].napi);
> + for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++)
> + airoha_qdma_clenaup_tx_queue(ð->q_tx[i]);
> +}
You don't appear to unregister the netdev. remove() should basically
be the reverse of probe().
Andrew
Powered by blists - more mailing lists