netdev - Re: [PATCH net-next 2/3] arm64: dts: airoha: Add EN7581 ethernet node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ffe4a56-c3fc-4553-aa32-c7a0d9780b5c@lunn.ch>
Date: Sun, 2 Jun 2024 19:49:29 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, conor@...nel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, catalin.marinas@....com,
	will@...nel.org, upstream@...oha.com,
	angelogioacchino.delregno@...labora.com,
	benjamin.larsson@...exis.eu
Subject: Re: [PATCH net-next 2/3] arm64: dts: airoha: Add EN7581 ethernet node

On Sun, Jun 02, 2024 at 07:38:17PM +0200, Lorenzo Bianconi wrote:
> > On Fri, May 31, 2024 at 12:22:19PM +0200, Lorenzo Bianconi wrote:
> > > Introduce the Airoha EN7581 ethernet node in Airoha EN7581 dtsi
> > > 
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > > ---
> > >  arch/arm64/boot/dts/airoha/en7581-evb.dts |  4 +++
> > >  arch/arm64/boot/dts/airoha/en7581.dtsi    | 31 +++++++++++++++++++++++
> > >  2 files changed, 35 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/airoha/en7581-evb.dts b/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > index cf58e43dd5b2..82da86ae00b0 100644
> > > --- a/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > +++ b/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > @@ -24,3 +24,7 @@ memory@...00000 {
> > >  		reg = <0x0 0x80000000 0x2 0x00000000>;
> > >  	};
> > >  };
> > > +
> > > +&eth0 {
> > > +	status = "okay";
> > > +};
> > 
> > Is that enough to make it useful? Don't you need a phy-handle, or
> > phy-mode?
> 
> This changes is actually in a subsequent patch (not posted yet) where I will
> add support for the mt7530 dsa switch. Do you prefer to add it here?

I would prefer you move this later when you add the switch.

	Andrew