netdev - Re: [EXTERNAL] [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c03c641-4727-4b75-b2b7-7dc48aebe8e8@lunn.ch>
Date: Sun, 2 Jun 2024 19:56:28 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nbd@....name" <nbd@....name>,
	"lorenzo.bianconi83@...il.com" <lorenzo.bianconi83@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"conor@...nel.org" <conor@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"will@...nel.org" <will@...nel.org>,
	"upstream@...oha.com" <upstream@...oha.com>,
	"angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com>,
	"benjamin.larsson@...exis.eu" <benjamin.larsson@...exis.eu>
Subject: Re: [EXTERNAL] [PATCH net-next 3/3] net: airoha: Introduce ethernet
 support for EN7581 SoC

> >+static void airoha_set_port_fwd_cfg(struct airoha_eth *eth, u32 addr, u32 val)
> >+{
> >+	airoha_fe_rmw(eth, addr, GDM1_OCFQ_MASK,
> >+		      FIELD_PREP(GDM1_OCFQ_MASK, val));
> 
> Not sure this is problem of my email client, but none of the functions args are aligning with above parenthesis
>               airoha_fe_rmw(eth, addr, GDM1_OCFQ_MASK,
>                                            FIELD_PREP(GDM1_OCFQ_MASK, val));

They look good to me. But they can 

I see from your mail headers you are using Exchange and other M$
things. Outlook is well known to corrupt emails, destroying white
space, wrapping lines etc. Your reply appears to of had some tabs
replaced by spaces, etc. Outlook is unusable for software engineers
handling patches.

	 Andrew