netdev - Re: [PATCH net 0/5] dst_cache: fix possible races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 03 Jun 2024 17:45:01 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net 0/5] dst_cache: fix possible races

On Fri, 2024-05-31 at 13:26 +0000, Eric Dumazet wrote:
> This series is inspired by various undisclosed syzbot
> reports hinting at corruptions in dst_cache structures.
> 
> It seems at least four users of dst_cache are racy against
> BH reentrancy.
> 
> Last patch is adding a DEBUG_NET check to catch future misuses.
>  
> Eric Dumazet (5):
>   ipv6: ioam: block BH from ioam6_output()
>   net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input()
>   ipv6: sr: block BH in seg6_output_core() and seg6_input_core()
>   ila: block BH in ila_output()
>   net: dst_cache: add two DEBUG_NET warnings
> 
>  net/core/dst_cache.c      |  2 ++
>  net/ipv6/ila/ila_lwt.c    |  7 ++++++-
>  net/ipv6/ioam6_iptunnel.c |  8 ++++----
>  net/ipv6/rpl_iptunnel.c   | 14 ++++++--------
>  net/ipv6/seg6_iptunnel.c  | 14 ++++++--------
>  5 files changed, 24 insertions(+), 21 deletions(-)
> 
LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@...hat.com>